Changing from Macports to Jhbuild #457
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 15, 2016 15:39
nmap-update now uses static libraries linking for libapr, libsvn, libserf, libz and libsqlite
That way, nothing is added if MAC_FLAGS is not specified.
|
Looks great, commit please! |
Author
|
Hello @dmiller-nmap, I just sent the commits to the SVN repository. Thanks for your review! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @bonsaiviking, this is an update of PR #420 containing the changes discussed in the conversation tab. I deleted this branch too so it was easier to send a new PR. Also I edited the
configurescript as you suggested, but should it be in configure.ac? And is it what you expected?