Add compatibility fixes for various OSes + multiplatform autobuilds for GitHub #3214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I updated the PR (force-pushed an updated set of commits) to remove a bunch of whitespace changes my editor introduced and I accidentally committed. |
Author
|
@NoClueMike Why was this closed without merging? You approved it... Did it make it in?? |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds compatibility fixes for FreeBSD, OpenBSD, NetBSD, Solaris, macOS and Windows, and build fixes for when optimizing build-times using
make -j3. I could not compilemasterout of the box on any of these OSes without these changes.This also adds autobuilds for those operating systems, proving these builds work, including auto-download and install of dependencies where necessary. Windows
Build.batreceived the most treatment in this regard (which is using an old toolchain). Example of what that looks like here.Yes I understand nmap is developed off of SVN and TravisCI (which I can't seem to see, publicly), but given the compilation problems I ran into across OSes, I have to believe the TravisCI setup lacks the coverage this gives you -- and you guys will get it for free, from GitHub, being a public repo.
EDIT: I updated the PR to remove a bunch of whitespace changes my editor introduced and I accidentally committed.