Merged
Conversation
water-sucks
approved these changes
Apr 28, 2025
Collaborator
water-sucks
left a comment
There was a problem hiding this comment.
Thanks for this! I appreciate the improvements :}
| }; | ||
|
|
||
| module = import ./module.nix flake-self; | ||
| module = lib.modules.importApply ./module.nix flake-self; |
Collaborator
There was a problem hiding this comment.
TIL about importApply, I'll definitely be using this in more of my Nix code from here on forth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started using
importApplyto import modules, a more modern way to do that.Also used the
finalAttrspattern for the package.And some other misc simplifications.