Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't bring any new features, but rather simplifies color handling.
In order to respect the user's preference for printing colors (i.e. for printing to a file), this adds a configuration setting and
a global flag that forces color even when printing to a file, much like
lessdoes.Additionally, this does a huge refactor of how colors are handled. Before, this used to just check the conditional directly and change the format string to have ANSI codes or not have ANSI codes. This is awkward as hell, since you have to do this everywhere and duplicate formatting logic in so many places that this becomes quite unwieldy. This creates an
ANSIFilterwriter that wraps over another writer, and either prints or doesn't print any ANSI codes that it encounters. That way, we only have to check in one place whether or not we should render these colors, provided that the developer is using the providedlogandutils.printutilities.