fix(diff): remove immutable flag from sqlite connection#210
fix(diff): remove immutable flag from sqlite connection#210water-sucks merged 1 commit intonix-community:mainfrom
Conversation
This flag was preventing either or both closure queries from returning results, causing empty or inaccurate diffs.
|
Hmm, I've actually noticed read errors when querying without this flag being specified, so we're gonna need to do a bit of research to figure out how consistent this is and if there's any alternatives. What is the error you get when this flag is specified? |
I don't see any errors, just no rows returned from the query. |
OK, my first guess is that with I have ran into a couple of errors in the past without this parameter related to failing reads, which only makes me think that it's related to this even more. However, after some testing, I'm unable to get a reproducible example of this error, hopefully it was just a development error on my part and this parameter is actually not needed. I'll approve it for now and hopefully no users run into errors since it's the new default differ. |
This flag was preventing either or both closure queries from returning results, causing empty or inaccurate diffs.