Skip to content

fix(diff): remove immutable flag from sqlite connection#210

Merged
water-sucks merged 1 commit intonix-community:mainfrom
Sporif:diff-fix-query
Apr 4, 2026
Merged

fix(diff): remove immutable flag from sqlite connection#210
water-sucks merged 1 commit intonix-community:mainfrom
Sporif:diff-fix-query

Conversation

@Sporif
Copy link
Copy Markdown
Collaborator

@Sporif Sporif commented Apr 4, 2026

This flag was preventing either or both closure queries from returning results, causing empty or inaccurate diffs.

This flag was preventing either or both closure queries from
returning results, causing empty or inaccurate diffs.
@water-sucks
Copy link
Copy Markdown
Collaborator

Hmm, I've actually noticed read errors when querying without this flag being specified, so we're gonna need to do a bit of research to figure out how consistent this is and if there's any alternatives.

What is the error you get when this flag is specified?

@Sporif
Copy link
Copy Markdown
Collaborator Author

Sporif commented Apr 4, 2026

Hmm, I've actually noticed read errors when querying without this flag being specified, so we're gonna need to do a bit of research to figure out how consistent this is and if there's any alternatives.

What is the error you get when this flag is specified?

I don't see any errors, just no rows returned from the query.

@water-sucks
Copy link
Copy Markdown
Collaborator

I don't see any errors, just no rows returned from the query.

OK, my first guess is that with immutable=1 data might not be getting synced from the WAL then?

I have ran into a couple of errors in the past without this parameter related to failing reads, which only makes me think that it's related to this even more.

However, after some testing, I'm unable to get a reproducible example of this error, hopefully it was just a development error on my part and this parameter is actually not needed. I'll approve it for now and hopefully no users run into errors since it's the new default differ.

@water-sucks water-sucks merged commit ad3c6b9 into nix-community:main Apr 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants