fix(apply): standardise --eval-only output#197
Merged
water-sucks merged 1 commit intonix-community:mainfrom Feb 26, 2026
Merged
fix(apply): standardise --eval-only output#197water-sucks merged 1 commit intonix-community:mainfrom
water-sucks merged 1 commit intonix-community:mainfrom
Conversation
The output from `apply --eval-only` with legacy `nixos-cli` is a very long attribute, which is probably not what the user expects. Fix that by copying the `nix-instantiate` arguments from the remote build case, so that only the drv path is outputted. The flake version is similarly adjusted. Also, adjust the log messages so that they follow the build only format by displaying: - a different step message for each build type - the drv path upon successful evaluation.
water-sucks
approved these changes
Feb 26, 2026
Collaborator
water-sucks
left a comment
There was a problem hiding this comment.
Fair enough, this makes sense in my testing.
| } | ||
|
|
||
| log.Info("evaluation successful") | ||
| log.Infof("the evaluated derivation is %v", drvPath) |
Collaborator
There was a problem hiding this comment.
Nit: would you think it's useful to output to stdout for usage in pipelines? Not really too much of a concern considering we don't do it for build-only anyway.
Collaborator
Author
There was a problem hiding this comment.
I think that is useful but probably best to solve in a separate issue/PR, as there may be more questions, e.g., what other options or commands could output useful data to stdout? Should we add json output?
Collaborator
There was a problem hiding this comment.
Yeah sounds good, we can talk about it later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output from
apply --eval-onlywith legacynixos-cliis a very long attribute, which is probably not what the user expects. Fix that by copying thenix-instantiatearguments from the remote build case, so that only the drv path is outputted. The flake version is similarly adjusted.Also, adjust the log messages so that they follow the build only format by displaying: