cmd/root/root.go (1)

32-34: Remove duplicate cobra.EnableTraverseRunHooks initialization.

After moving this to init(), the assignment in Execute() is redundant. Keep it in one place to avoid configuration drift.

Proposed cleanup

 func Execute() {
-	cobra.EnableTraverseRunHooks = true
-
 	cmd, err := mainCommand()
 	if err != nil {
 		os.Exit(1)
 	}

Also applies to: 179-181

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@cmd/root/root.go` around lines 32 - 34, The init() function already sets
cobra.EnableTraverseRunHooks, so remove the redundant assignment from Execute()
(and any other duplicate at the other mentioned location) to keep configuration
in one place; locate the duplicate use of cobra.EnableTraverseRunHooks in the
Execute() function and delete that line, leaving the init() initialization as
the sole assignment.

cmd/generation/rollback/rollback.go (1)

72-74: Consider updating the comment to reflect the new differ options.

The comment mentions "nvd" and "nix store diff-closures" but doesn't account for the new internal differ, which is now the default. Consider updating to reflect all available differ options.

📝 Suggested comment update

 	// While it is possible to use the `rollback` command, we still need
 	// to find the previous generation number ourselves in order to run
-	// `nvd` or `nix store diff-closures` properly.
+	// the configured differ properly.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@cmd/generation/rollback/rollback.go` around lines 72 - 74, Update the
explanatory comment above the rollback logic to mention the new internal differ
(now the default) alongside the legacy tools; specifically reference the
`rollback` command behavior and list/acknowledge the available differ options
(e.g., the internal differ, `nvd`, and `nix store diff-closures`) so the comment
reflects current behavior and choices used when finding the previous generation
number in functions around rollback handling in rollback.go.

internal/settings/completion.go (1)

30-31: Inconsistent use of reflect.Pointer vs reflect.Ptr.

Lines 30 and 42 use reflect.Pointer, but line 60 still uses reflect.Ptr. While both are functionally equivalent (aliases since Go 1.18), consider using one consistently throughout the file for clarity.

♻️ Suggested fix for consistency

 	if current.Kind() == reflect.Ptr {
+	if current.Kind() == reflect.Pointer {
 		if current.IsNil() {
 			current.Set(reflect.New(current.Type().Elem()))
 		}
 		current = current.Elem()
 	}

Also applies to: 42-48, 60-65

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@internal/settings/completion.go` around lines 30 - 31, The code uses both
reflect.Pointer and reflect.Ptr inconsistently (seen where current.Kind() is
compared), so standardize on one alias throughout the file (e.g., replace all
occurrences of reflect.Pointer with reflect.Ptr or vice versa) so every check
like current.Kind() == reflect.Pointer/current.Kind() == reflect.Ptr uses the
same symbol; update every instance in internal/settings/completion.go (including
the blocks around the current.Kind() checks and any other uses) to the chosen
alias for consistency.

internal/diff/diff.go (1)

218-237: Redundant changed variable.

The changed variable (line 218-221) duplicates the condition already checked at line 233. The logic can be simplified.

Proposed simplification

 			if len(uniqueOldVersions) == 0 && len(uniqueNewVersions) == 0 {
 				continue
 			}

-			changed := false
-			if len(uniqueOldVersions) > 0 && len(uniqueNewVersions) > 0 {
-				changed = true
-			}
-
 			diff := PathDiff{
 				Name: name,
 			}

 			if len(uniqueOldVersions) > 0 && len(uniqueNewVersions) == 0 {
 				diff.Change = ChangeTypeRemove
 				diff.Old = uniqueOldVersions
 			} else if len(uniqueOldVersions) == 0 && len(uniqueNewVersions) > 0 {
 				diff.Change = ChangeTypeAdd
 				diff.New = uniqueNewVersions
-			} else if changed {
+			} else {
+				// Both have unique versions - this is a change
 				diff.Change = ChangeTypeChange
 				diff.Old = uniqueOldVersions
 				diff.New = uniqueNewVersions
 			}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@internal/diff/diff.go` around lines 218 - 237, The local boolean variable
`changed` is redundant—remove its declaration and assignment and instead use the
direct condition when building the PathDiff: replace the `else if changed { ...
}` branch with `else if len(uniqueOldVersions) > 0 && len(uniqueNewVersions) > 0
{ ... }`, leaving the other branches that set `diff.Change` to
ChangeTypeRemove/Add and populate `diff.Old`/`diff.New` unchanged; this
simplifies the logic around constructing the PathDiff (the surrounding symbols
are `changed`, `PathDiff`, `ChangeTypeChange`, `ChangeTypeRemove`,
`ChangeTypeAdd`, and the slices `uniqueOldVersions`/`uniqueNewVersions`).