refactor(system): make root cmd+flags a property of the command struct#181
Merged
water-sucks merged 1 commit intonix-community:mainfrom Feb 17, 2026
Merged
Conversation
22b663e to
bb4577a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running SSH commands with a root elevation command like
sudo, this didn't quite work in all cases when passing environment variables. That is because the root command was simply getting replaced in the command'sNamestring andArgsslice, rather than being treated specially.This resulted in invocations of
sh -c "export VAR=value; set -- <root cmd flags> <args>; sudo exec $@", which ended up wiping the set environment variables after elevation, rather thansudo <root cmd flags> sh -c "export VAR=value; set -- <args>; exec $@", which would preserve the set variables likeVARthrough SSH and through the root command env var sanitation process.This PR refactors the root command and possible root command flags into specific
Commandfields so that this distinction can be made when creating the shell wrapper on SSH systems to preserve env vars.Closes #180.