fix(apply): fix resultLocation variable shadowing in build path#169
Merged
water-sucks merged 1 commit intonix-community:mainfrom Feb 7, 2026
Merged
fix(apply): fix resultLocation variable shadowing in build path#169water-sucks merged 1 commit intonix-community:mainfrom
water-sucks merged 1 commit intonix-community:mainfrom
Conversation
The := operator was creating a new local resultLocation variable
inside the if block, leaving the outer variable empty (""). This
caused the diff command to receive an empty path:
$ nvd diff /run/current-system
error: a value is required for '\''[AFTER]'\'' but none was supplied
Changed := to = with a pre-declared err variable so the build
result path correctly assigns to the outer resultLocation.
water-sucks
approved these changes
Feb 7, 2026
Collaborator
water-sucks
left a comment
There was a problem hiding this comment.
Thank you so much for catching this! This slipped past past me when reviewing/testing somehow.
Collaborator
|
Oof, sorry about that. Strangely, go warned me about this in an earlier version, but later somehow didn't... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The := operator was creating a new local resultLocation variable
inside the if block, leaving the outer variable empty (""). This
caused the diff command to receive an empty path:
Changed := to = with a pre-declared err variable so the build
result path correctly assigns to the outer resultLocation.