fix(apply): reduce restrictions on certain options#168
Merged
water-sucks merged 1 commit intonix-community:mainfrom Feb 7, 2026
Merged
Conversation
- Allow passing `--no-activate` and `--no-boot` without having to specify `--output` or `--dry` - When only building, print a log message to indicate the store path built. - Allow setting `--output` with `--build-host` and/or `--target-host` - Don't change the working directory, it's not necessary for getting the latest commit message. - Don't unnecessarily combine the output path with the working directory.
water-sucks
approved these changes
Feb 7, 2026
Collaborator
water-sucks
left a comment
There was a problem hiding this comment.
Frankly, I'm not sure why I kept the CWD change in this; this was an artifact of the Zig -> Go port since it was necessary over there for a reason I don't remember.
This totally works! Makes it simpler to grok so I'm good with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow passing
--no-activateand--no-bootwithout having to specify--outputor--dry.It is useful to just test your configuration builds without creating a gc root and cluttering the filesystem.
When only building, print a log message to indicate the store path built.
This is mainly for when
--outputis not set, but I think it's useful to always show it when building only e.g., to be able to quickly copy the built store path for use in other commands. Also,nixos-rebuild-ngdoes this (and shows the store path even when switching).Allow setting
--outputwith--build-hostand/or--target-hostTo allow re-using aliases that set
--output ./resultwith remote builds or activation.Don't change the working directory, it's not necessary for getting the latest commit message.
Don't unnecessarily combine the output path with the working directory.
These last two changes are unrelated but I think they simplify the code at no cost. Happy to remove them if it should be a separate PR or if they are actually necessary.