fix: Support quoted attribute names#165
Merged
water-sucks merged 1 commit intonix-community:mainfrom Feb 10, 2026
Merged
Conversation
42ec377 to
3b18215
Compare
water-sucks
requested changes
Feb 4, 2026
Collaborator
water-sucks
left a comment
There was a problem hiding this comment.
This is a good start! Really appreciate the time you took for this so far.
6cb3aa7 to
8b9b1fe
Compare
water-sucks
requested changes
Feb 9, 2026
Collaborator
There was a problem hiding this comment.
Couple of variable shadowing issues.
I'll enable a golangci-lint linter for this in the future, but it does tend to be rather strict. Strict may be better than lax in this case though, since Go's shadowing rules have already caused bugs in the past.
Edit: Done in #172
8b9b1fe to
f8ae445
Compare
water-sucks
approved these changes
Feb 10, 2026
Collaborator
water-sucks
left a comment
There was a problem hiding this comment.
This is amazing now! I really appreciate your contributions thus far.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for Nix attribute names containing spaces and dots. It involves creating two new types to represent attribute names and paths, and replacing
fmt.Sprintf()calls with functions that use these types. It also addsFlakeRefandLegacyConfigurationfunctions to format common NixOS configuration attributes.I have tested local flake and legacy builds, images, specialisations, VMs, and evaluation of option values. I have not tested remote building (but it should also work).
Closes #126.