fix(apply): validate system closure#158
Merged
water-sucks merged 1 commit intonix-community:mainfrom Jan 30, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
water-sucks
requested changes
Jan 27, 2026
0cb7484 to
8648d7f
Compare
water-sucks
reviewed
Jan 28, 2026
8648d7f to
fc48f4f
Compare
water-sucks
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tests for the existence of the
nixos-versionfile in the system closure before setting the new system profile.This is needed because of a nix bug (NixOS/nix#13367) that means that running
nixos applywith apath:orgit+file:flake URL and the current working directory set to a store path (or symlink to a store path) leads to said store path as the built system closure.(See NixOS/nixpkgs@ae48ab38 and NixOS/nixpkgs@0f6624e2)