fix(apply): Fix dry builds#157
Merged
water-sucks merged 1 commit intonix-community:mainfrom Jan 28, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2900624 to
a2162b3
Compare
water-sucks
approved these changes
Jan 28, 2026
Collaborator
water-sucks
left a comment
There was a problem hiding this comment.
Ahhh, this is a nice catch! I do not use dry builds very often, no idea how this slipped into here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The man page states that the dry-build alias is
nixos apply --dry --no-activate --no-boot --output ./result, but this does not work as--dryand--outputare mutually exclusive flags.Removing
--outputthen triggers a validation error, since the code currently requires--outputwhen both--no-activateand--no-bootare set, which are themselves required for a dry build.This change updates the logic to allow either
--outputor--dryin this case, and adjusts the man page to use the correct alias.