fix(enter): Fix resolv.conf bind-mount#154
Merged
water-sucks merged 1 commit intonix-community:mainfrom Jan 29, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
water-sucks
requested changes
Jan 28, 2026
The previous implementation led to incorrect target resolv.conf paths. Switch to using openat2 to handle a symlink by directly opening it and the "new" mount api to mount over it. Using file descriptors also helps us avoid TOCTOU bugs.
37daf12 to
b4f7538
Compare
water-sucks
approved these changes
Jan 29, 2026
Collaborator
water-sucks
left a comment
There was a problem hiding this comment.
NIce work! Again, really appreciate the improvements you have been making to this codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation led to incorrect target resolv.conf paths. Switch to using openat2 to handle a symlink by directly opening it and the "new" mount api to mount over it.
I also have an older branch that just copies the
nixos-enterimplementation more closely, if that's preferable.