fix(enter): inherit parent PID namespace#152
Merged
water-sucks merged 1 commit intonix-community:mainfrom Jan 22, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
water-sucks
approved these changes
Jan 22, 2026
Collaborator
water-sucks
left a comment
There was a problem hiding this comment.
Thank you! It is hard to keep feature parity with nixpkgs since I'm pretty busy these days, so this is well appreciated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit: NixOS/nixpkgs@798aa80
This is to stop systemd detecting the chroot as a container, and thus inhibiting
bootctlfrom populating EFI variables.It can be tested with
nixos enter -c systemd-detect-virt, which outputskvmwith the fix, andcontainer-otherwithout it.