internal/system/local.go (2)

42-61: Signal forwarding implementation looks correct.

The approach of using Start() followed by Wait() with a signal-forwarding goroutine properly addresses the missing local signal forwarding. The cleanup via defer ensures the signal handler is unregistered and the goroutine exits cleanly.

One minor refinement: registering the signal handler before calling Start() would eliminate a small race window where signals arriving between Start() and Notify() might not be forwarded. The existing nil-check on command.Process already handles this safely.

Optional: Eliminate signal race

Move the signal setup before Start():

+	sigs := make(chan os.Signal, 1)
+	signal.Notify(sigs, syscall.SIGINT, syscall.SIGTERM)
+	defer func() {
+		signal.Stop(sigs)
+		close(sigs)
+	}()
+
 	if err := command.Start(); err != nil {
 		return 0, err
 	}

-	sigs := make(chan os.Signal, 1)
-	signal.Notify(sigs, syscall.SIGINT, syscall.SIGTERM)
-	defer func() {
-		signal.Stop(sigs)
-		close(sigs)
-	}()
-
 	go func() {
 		for sig := range sigs {
 			if command.Process != nil {
 				_ = command.Process.Signal(sig)
 			}
 		}
 	}()

---

56-56: Consider logging signal forwarding errors.

While ignoring the error from Process.Signal() is reasonable for signal forwarding, logging failures would aid debugging if signal delivery issues arise.

-				_ = command.Process.Signal(sig)
+				if err := command.Process.Signal(sig); err != nil {
+					l.logger.Debugf("failed to forward signal %v: %v", sig, err)
+				}

internal/system/ssh.go (1)

353-384: Signal mapping correctly implements SSH protocol requirements.

The osSignalToSSHSignal() function properly maps OS signals to SSH signal names (without the "SIG" prefix), fixing the bug described in the PR. The mapped signals align with RFC 4254 section 6.10.

The default case returning an empty string for unmapped signals is reasonable since not all OS signals have SSH protocol equivalents. However, logging unmapped signals would help identify unexpected signal types during debugging.

 	default:
+		// Log unmapped signals for debugging
+		// Most signals (SIGSTOP, SIGCONT, SIGCHLD, etc.) cannot be forwarded via SSH
 		return ""
 	}

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro