fix(install): use cobra.Command to set include flag for nixos-config value#109
Merged
water-sucks merged 1 commit intonix-community:mainfrom Oct 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
nixos-config=value was not getting copied into the command array fornixos install, since it was not set in the actualcobra.Commandpflag set for theinstallsubcommand. Because of this, the translation layer ignored the value for theincludeflag for thenixos-config=value and thus was installing the WRONG CONFIGURATION into the destination.As such, this is a HUGE problem with legacy installs, I should have tested this better, unfortunately.
This PR sets the flag properly using the pflag
Set()construct.