Fix line indentation stripping#62
Merged
asymmetric merged 4 commits intonix-community:masterfrom Jul 28, 2023
Merged
Conversation
2 tasks
Collaborator
Author
pennae
reviewed
Jul 20, 2023
pennae
approved these changes
Jul 20, 2023
Contributor
pennae
left a comment
There was a problem hiding this comment.
looks alright :)
hoping we'll at some point get an actual standard notation instead of the hacky parser we have now being used as a definition though
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-07-24-documentation-team-meeting-notes-66/30885/1 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-07-27-documentation-team-meeting-notes-67/30998/1 |
9bc64be to
33482e7
Compare
Previously all the indentation was stripped all the time Co-authored-by: pennae <82953136+pennae@users.noreply.github.com>
Arguably this shouldn't even be allowed, but erroring would not be in line with how nixdoc works otherwise :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, line indentations being stripped.
This work is sponsored by Antithesis ✨
Ping @pennae