fix(netlify, aws): omit cookies from v1 response#834
Merged
Conversation
Member
|
Have you had a chance to test changes? |
Codecov Report
@@ Coverage Diff @@
## main nuxt/framework#834 +/- ##
==========================================
- Coverage 69.93% 69.88% -0.05%
==========================================
Files 57 57
Lines 5312 5307 -5
Branches 594 594
==========================================
- Hits 3715 3709 -6
- Misses 1588 1589 +1
Partials 9 9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
Author
|
I've tested changes within netlify environment but haven't directly on AWS. I'm going directly off the docs here: https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations-lambda.html. Testing would be welcome. |
|
Hi! I just tested this on AWS Lambda, I can confirm this fixes nuxt/framework#504 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #504
also nuxt/nuxt#15361
❓ Type of change
📚 Description
This omits responding with cookies on aws lambda v1 format.
📝 Checklist