• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch refactor/vite-rollup

Reviewing files that changed from the base of the PR and between f661802 and a30f777.

• src/build/vite/env.ts (3 hunks)

• GitHub Check: publish-pkg-pr-new

src/build/vite/env.ts (5)

1-1: LGTM! Proper type import added.

The addition of RollupCommonJSOptions import improves type safety for the commonjsOptions configuration on line 29.

---

25-25: LGTM! Improved type safety by removing as any cast.

Removing the type assertion improves compile-time type checking and makes the code more maintainable.

---

29-29: Note the change from defensive copy to direct reference.

The previous code used object spreading ({ ...ctx.nitro!.options.commonJS }) which created a shallow copy, while the new code directly assigns the reference with a type cast. This is likely fine as Vite typically doesn't mutate configuration objects, but be aware that any mutations to commonjsOptions by Vite would now affect the original object.

---

44-49: LGTM! Standard Vite define pattern for NODE_ENV.

The define block correctly sets process.env.NODE_ENV at build time using JSON.stringify, which is the standard approach for Vite. The comment clearly documents the tanstack-start devtools use case.

---

62-92: Address recurring issues with external dependency handling in service builds.

The removal of noExternal configuration from service environments (commit d34a045) was intended to keep dependencies external, but git history reveals this caused immediate breakage: commit 9b276e1 ("temp fix for react bundling") re-added noExternal: [/react/] specifically to fix React bundling failures with tanstack-start. The current code shows no explicit handling for React or other external dependencies in production service builds.

Service environments rely solely on externalConditions filtering (which excludes browser/wasm conditions), but lack the previous noExternal safeguards that were intentionally removed. This behavioral change needs validation to ensure service builds correctly handle framework dependencies like React in both development and production modes, particularly for frameworks like tanstack-start that depend on proper bundling behavior.