feat: allow edit of commonJs plugin params#187
Merged
pi0 merged 6 commits intonitrojs:mainfrom May 4, 2022
Merged
Conversation
- add commonjs field to edit the commonjs plugin
pi0
reviewed
May 3, 2022
src/types/nitro.ts
Outdated
| externals: NodeExternalsOptions | ||
| analyze: false | PluginVisualizerOptions | ||
| replace: Record<string, string | ((id: string) => string)> | ||
| commonJs?: RollupCommonJSOptions |
Member
There was a problem hiding this comment.
Can you please use commonJS for naming?
pi0
reviewed
May 3, 2022
Member
pi0
left a comment
There was a problem hiding this comment.
Thanks! Would be nice to also update docs (config reference to mention this new option)
1a9b45b to
672b00b
Compare
7 tasks
danielroe
reviewed
May 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
nuxt/framework#4762
nuxt/nuxt#13843
❓ Type of change
📚 Description
Add the commonJs key to NitroOptions and assign by destructuring nitro.option.commonJs when adding the @rollup/plugin-commonjs.
Would improve the linked PR by avoiding replacing the commonJS plugin at build. The commonJS dynamicRequireTargets declaration would be directly into nitro/nuxt config
📝 Checklist