Merged
Conversation
Shivam010
requested changes
Mar 18, 2023
Collaborator
Shivam010
left a comment
There was a problem hiding this comment.
The changes look good to me. Thanks @YafimK for the PR.
Additionally, it seems that with go-redis@v9 we can support Go versions: [ 1.13, 1.14, 1.15 ], which is causing tests to fail. Can you update the go version in the workflow file to [ 1.20 ] ?
https://github.com/nitishm/go-rejson/blob/master/.github/workflows/test.yml#L9
Also, the linters in code-analysis.yml are also failing due to some version issues. Are we willing to look into it? We can have a separate PR also for the linters fix.
Shivam010
reviewed
Mar 19, 2023
Pull Request Test Coverage Report for Build 4520503214
💛 - Coveralls |
|
Seems all requested changes were made to me, right? When is this due to merge? I'd be more than happy to be able to use this. |
Shivam010
approved these changes
Mar 31, 2023
Collaborator
|
Sorry for the delay. Looks like we are all set. Thanks for the PR @YafimK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the support for go-redis libary to latest v9