Add Github actions for Pull Requests#58
Conversation
| for _, s := range _lst { | ||
| by = append(by, byte(s)) | ||
| } |
There was a problem hiding this comment.
Yup, I remembered the JSONType and some other methods did have some different customized output which was causing problems when used directly.
I'll look into it tomorrow, it's pressing now.
https://github.com/nitishm/go-rejson/runs/4808164372?check_suite_focus=true#step:5:263
There was a problem hiding this comment.
@breno12321
Let's continue the encoding issue in #57 and merge this here with only the workflow yaml changes.
Can you remove your changes from rjs/helper.go file, so that we can merge this?
|
Oh sorry I thought I didn't sent them together |
|
@Shivam010 Uhm why it still don't pass even though its just github actions change 🤔 |
Pull Request Test Coverage Report for Build 1697907725
💛 - Coveralls |
|
It's the version issue, we are using the latest version of Redislabs have changed some command responses after For now, limiting the support to 1.0.8 and merging changes |
|
Ignoring the |
|
Thanks <3 |
No description provided.