FIX: Correctly cast nan when testing array_to_file- fixes ARM64 builds#862
FIX: Correctly cast nan when testing array_to_file- fixes ARM64 builds#862effigies merged 4 commits intonipy:maint/3.1.xfrom
nan when testing array_to_file- fixes ARM64 builds#862Conversation
Codecov Report
@@ Coverage Diff @@
## maint/3.1.x #862 +/- ##
===============================================
- Coverage 91.81% 91.77% -0.05%
===============================================
Files 97 97
Lines 12359 12359
Branches 2177 2177
===============================================
- Hits 11348 11343 -5
- Misses 678 681 +3
- Partials 333 335 +2
Continue to review full report at Codecov.
|
|
According to https://docs.travis-ci.com/user/multi-cpu-architectures/#testing-on-multiple-cpu-architectures, we can also check on Also, there's OSX support, so we should at least test on that. |
|
@matthew-brett The ARM64 jobs require building numpy from source every time, and we don't currently have the necessary C dependencies installed. Would it be reasonable to open a PR against numpy-wheels to add non-x86 wheels to their .travis.yml? Would anything else be required apart from updating multibuild? |
|
can you use miniconda? there are arm64 and powerpc miniconda installations, and numpy is compiled for arm64 and powerpc (https://anaconda.org/conda-forge/numpy). |
|
Numpy is working on wheels on their end. I don't think it's too urgent to wait on that. |
dcd0bfc to
d581590
Compare
nan when testing array_to_file- fixes ARM64 builds
|
Anybody up for a review? Will merge Friday if nobody shouts. |
|
Looks right to me - thanks for tracking that down. |
|
Great, thanks for having a look. |
Trying to replicate #861.
Closes #861.