Use PyJObject ClassLoader instead of jep.forName in java import hook.#617
Merged
bsteffensmeier merged 1 commit intoOct 28, 2025
Merged
Conversation
ndjensen
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of my efforts to make jep more functional from java created threads. This adds a class loader to the java import hook. Since
jep.forName()is callingClassLoader.loadClass()internally using the same class loader that is used to construct the interpreter instance this change should not be changing any actual behavior of the java import hook. However since the class loader in the jep thread state is not available on python created threads and the class loader in the hook is available on those threads this will allow the hook to work on python created threads.