Expose PyConfig options for isolation and arg parsing.#596
Merged
Conversation
ndjensen
reviewed
Feb 20, 2025
| config.parse_argv = 0; | ||
| if (parseArgv >= 0) { | ||
| config.parse_argv = 0; | ||
| } |
Member
There was a problem hiding this comment.
This confuses me. The options are 0 or 1, so how do you set it to 1 with this code? https://docs.python.org/3/c-api/init_config.html#c.PyConfig.parse_argv
Member
Author
There was a problem hiding this comment.
That is definitely an oversight on my part. Thanks for pointing it out. I've fixed it in the latest commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on the changes in #586 and further improves the compatibility with the c-api. In that change I hardcoded the option to disable argv parsing however there may be use cases where someone wants to enable that parsing. To keep things consistent with the c-api the option is exposed in Java and Jep will no longer set the value of that option unless it is set in Java.
This also exposes the ability to create an isolated python configuration. For backwards compatibility the default is to use a config which behaves like regular python but the c-api includes a function to create an isolated python so I thought it would be useful to allow that option in Java.