Switch build to setuptools.#396
Merged
Merged
Conversation
ndjensen
approved these changes
May 9, 2022
Member
|
We need to add a pyproject.toml file that specifies we depend on setuptools. See PEP-518 and other Python projects. |
Member
|
I just reread it and I guess we don't need a pyproject.toml file if we don't want one. "Because the use of setuptools and wheel are so expansive in the community at the moment, build tools are expected to use the example configuration file above as their default semantics when a pyproject.toml file is not present." The example configuration file has setuptools and wheel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #354. This change eliminates the DeprecationWarning during the build.
This does not remove every reference to distutils but I believe that any remaining references to distutils will continue to work after distutils is removed in Python 3.12 because of the distutils_hack in setuptools.
Many of the distutils references are related to choosing the c compiler in windows, since I do not have a local windows machine for testing I did not put any effort into windows. I did verify this change builds on windows on AppVeyor. I also have not tested on mac.
A few of the distutils references have open issues or fixes in newer versions of setuptools. I added comments to the setuptools issues and left the distutils code in for now so we are compatible with older versions of setuptools.