Skip to content

Fixed library location for Python 3.10.#375

Merged
bsteffensmeier merged 1 commit into
ninia:dev_4.0from
notiska:fix-library-location
Feb 12, 2022
Merged

Fixed library location for Python 3.10.#375
bsteffensmeier merged 1 commit into
ninia:dev_4.0from
notiska:fix-library-location

Conversation

@notiska

@notiska notiska commented Feb 9, 2022

Copy link
Copy Markdown
Contributor

When checking for the Python library path, the pattern would not match more than one number.
This means that jep would not be able to find the shared library for Python 3.10 installations.

@notiska notiska changed the base branch from master to dev_4.0 February 9, 2022 18:25

@bsteffensmeier bsteffensmeier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

I think this change is minor enough to go in a 4.0.2 release, @ndjensen do you agree?

@ndjensen ndjensen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that this would be good in 4.0.2. Thanks for the fix!

@bsteffensmeier bsteffensmeier merged commit efde9b5 into ninia:dev_4.0 Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants