Conversation
Contributor
thirdeyenick
left a comment
There was a problem hiding this comment.
Thanks! Looking good. Just a question: is the COMP_LINE env variable a shell specific thing or is this the same for any shell?
Member
Author
It's a package specific one. So it works the same for all shells. |
Contributor
Thx! |
thirdeyenick
approved these changes
Jan 29, 2026
Member
Author
|
Well that wasn't really correct. It's standard for Bash, but the library configures it as well for fish and uses bash completion for zsh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes shell completion not finding resources when using
--projectflag and updateds kong-completion to v0.0.11.When completing positional arguments in nested subcommands, the posener/complete library slices args.All as it descends through subcommands, making the
--projectflag unavailable to the predictor.I also added tests using
complete.New()to verify the actual completion behavior.Manual Test