Skip to content

adding flags and new funcions for the sensitive fields#269

Merged
SaadAssaf merged 1 commit intomainfrom
nctl_sensitiveField
Sep 22, 2025
Merged

adding flags and new funcions for the sensitive fields#269
SaadAssaf merged 1 commit intomainfrom
nctl_sensitiveField

Conversation

@SaadAssaf
Copy link
Contributor

@SaadAssaf SaadAssaf commented Aug 25, 2025

We've added new flags (--sensitive-env and --sensitive-build-env) to the create and update commands. These flags allow users to mark variables as sensitive.

Masking logic were created to redact their values (*****) in the command output.

./nctl get configs
PROJECT    NAME    SIZE    REPLICAS    PORT    ENVIRONMENT_VARIABLES    BASIC_AUTH    DEPLOY_JOB    AGE
test             test                                                  env_test=*****           false         <none>        14m

Note: We didn't apply masking for YAML or JSON output. This is by design because these formats are used by automation tools etc

@SaadAssaf SaadAssaf force-pushed the nctl_sensitiveField branch 2 times, most recently from 3eeb079 to a5492a4 Compare September 19, 2025 12:54
thirdeyenick
thirdeyenick previously approved these changes Sep 19, 2025
Copy link
Contributor

@thirdeyenick thirdeyenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Lgtm!

@thirdeyenick thirdeyenick dismissed their stale review September 19, 2025 14:34

I forgot to check the project_config tests. We need a test there to make sure that the normal output of the project config sensitive environment variables is masked.

This change adds new flags (--sensitive-env and --sensitive-build-env) to the application create and update commands. These flags let users add to  environment variables  sensitive=true.
masking logic was added too to make their values hidden from the command output. Test cases were added to confirm that sensitive environment variables are correctly handled.
Copy link
Contributor

@thirdeyenick thirdeyenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

@SaadAssaf SaadAssaf merged commit 1ccc930 into main Sep 22, 2025
3 checks passed
@SaadAssaf SaadAssaf deleted the nctl_sensitiveField branch September 22, 2025 13:49
@SaadAssaf
Copy link
Contributor Author

ninech/platform/mono-infra#1427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants