fix: possibly fix the scrollbar in all charts#1
Merged
nickofthyme merged 1 commit intonickofthyme:fix/tooltip-scrollfrom Apr 24, 2020
Merged
fix: possibly fix the scrollbar in all charts#1nickofthyme merged 1 commit intonickofthyme:fix/tooltip-scrollfrom
nickofthyme merged 1 commit intonickofthyme:fix/tooltip-scrollfrom
Conversation
nickofthyme
approved these changes
Apr 24, 2020
Owner
|
Yup I totally forgot to account for that after it switches. I'll add this to my PR and look at the other issue to noted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
it's a partial fix for the scrollbar PR.
if you comment out the changes done in

tooltip/utils.tsandportalyou can see the current behavior of the "red" portal: we need to "switch" the portal when the portal is overflowing the chart edge. The current behavior instead take into consideration the tooltip width and not the portal width.
This fix add an anchor point to anchor the tooltip at the left or right of the portal depending if we flipped the portal to the right or left of the mouse position
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts(and stories only import from../srcexcept for test data & storybook)