Fixed issue with temp files crashing precompiler#3
Closed
paton wants to merge 3 commits into
Closed
Conversation
Owner
|
Hi paton, I realize this is a year old but I'd be interested in merging it. Is there a reason you removed several console.log()s? |
Contributor
Author
|
I think it's generally best practice for node modules not to output things to the console. Console.log()s might be useful for debugging purposes, though. Maybe the 4th argument on watchDir can be |
Owner
|
I would agree, or at least make the output optional. As you've noted, there's another pull request that is making the console.logs optional which is great. For the purposes of this PR, would you want to revert the |
Owner
|
Merged your fix into 16a3f4d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a simple check to block temp files from accidentally being sent into processTemplate(), which crashes the process.