Merged
Conversation
lja1018
reviewed
May 28, 2021
array/zip.js
Outdated
| * // const zip = require('tui-code-snippet/array/zip'); // CommonJS | ||
| * | ||
| * var result = zip([1, 2, 3], ['a', 'b','c'], [true, false, true]); | ||
| * const result = zip([1, 2, 3], ['a', 'b','c'], [true, false, true]); |
customEvents/customEvents.js
Outdated
| * // const CustomEvents = require('tui-code-snippet/customEvents/customEvents'); // CommonJS | ||
| * | ||
| * var model; | ||
| * let model; |
There was a problem hiding this comment.
아래에서 바로 const model = new Model();로 수정해도 될것 같아요.
| * var repository = {name: 'CodeSnippet'}; | ||
| * const name = 'global'; | ||
| * const repository = {name: 'CodeSnippet'}; | ||
| * on(div, 'drag', function() { |
Contributor
Author
There was a problem hiding this comment.
on에 인자로 전달되는 콜백함수는 뒤 따른 인자인 repository를 바인딩해서 사용하는 구조로 작성되어 있습니다.
따라서 화살표 함수로 변경하면 이를 바인딩 할 수 없어서 오류가 발생하게 됩니다.
jungeun-cho
reviewed
May 28, 2021
array/range.js
Outdated
| * @example | ||
| * var range = require('tui-code-snippet/array/range'); // node, commonjs | ||
| * import range from 'tui-code-snippet/array/range'; // ES6 | ||
| * // const range = require('tui-code-snippet/array/range'); // CommonJS |
Contributor
Author
There was a problem hiding this comment.
이미 ES6로 변경되어 있는 문서들을 참고 해서 작업했습니다!
https://nhn.github.io/tui.date-picker/latest/Calendar
DatePicker가 적용되어 있는 문서인데, 여기서 주석을 이용해 작성해서 이 형태를 따라 갔습니다.
[공통]
주석처리는 제거하고 브라우저 환경에 대한 명시를 추가하도록 하겠습니다!
jungeun-cho
reviewed
May 28, 2021
jungeun-cho
left a comment
There was a problem hiding this comment.
[공통] ES6, CommonJS 작성할 때 CommonJS부분을 주석처리한 이유가있을까요?
예제부분이라 주석처리안해도될것같아서요.
chore: let to const
7c75d41 to
febe2c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨