Skip to content

fix: splitByRegExp for IE8#43

Merged
heenakwag merged 6 commits intomasterfrom
fix/regexp-for-ie8
Dec 19, 2019
Merged

fix: splitByRegExp for IE8#43
heenakwag merged 6 commits intomasterfrom
fix/regexp-for-ie8

Conversation

@heenakwag
Copy link
Member

@heenakwag heenakwag commented Dec 12, 2019

Other browsers except IE8

var regexp = '/{{|}}/'
console.log(splitByRegExp('{{test}}', regexp)); // ['', 'test', '']

Before (IE8)

var regexp = '/{{|}}/';
console.log('{{test}}'.split(regexp)); // ['test']

After (IE8)

var regexp = '/{{|}}/'
console.log(splitByRegExp('{{test}}', regexp)); // ['', 'test', '']

seonim-ryu
seonim-ryu reviewed Dec 12, 2019
View reviewed changes
jung-han
jung-han reviewed Dec 12, 2019
View reviewed changes
jung-han
jung-han reviewed Dec 12, 2019
View reviewed changes
@heenakwag heenakwag merged commit bfc625b into master Dec 19, 2019
@heenakwag heenakwag deleted the fix/regexp-for-ie8 branch December 19, 2019 01:59
@snyk-bot snyk-bot mentioned this pull request Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@seonim-ryu seonim-ryu seonim-ryu left review comments

@jung-han jung-han jung-han left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@heenakwag @seonim-ryu @jung-han