Improve type safety of TranslateService and TranslatePipe#1529
Merged
Conversation
|
Would love this! Makes the pipe much easier to use in strict mode. |
CodeAndWeb
reviewed
May 16, 2025
CodeAndWeb
left a comment
Member
There was a problem hiding this comment.
Looks good to me.
I am a fan of stricter checks anyways... :-)
CodeAndWeb
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
TranslatePipenow explicitly acceptsnullandundefinedand returnsTranslation. The code already guards against falsy values and specifying it explicitly helps when used withstrictNullChecksintsconfig. Otherwise, you may get a bunch of errors when an optional or nullable field is passed to the pipe.anywithunknowninInterpolationParams.