Skip to content

ci: fix remaining errors in main build#5044

Merged
brandonroberts merged 5 commits intomainfrom
main-ci-v2
Dec 15, 2025
Merged

ci: fix remaining errors in main build#5044
brandonroberts merged 5 commits intomainfrom
main-ci-v2

Conversation

@timdeschryver
Copy link
Copy Markdown
Member

@timdeschryver timdeschryver commented Dec 8, 2025 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The main build still fails.

What is the new behavior?

  • Split all type tests in effects because these are causing timeouts. Also reword the test names (remove the "should" form). This doesn't fix all issues, therefor the timeout is increased for all type tests.
  • Mock console.error, this is causing noise in the output.

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link
Copy Markdown

netlify bot commented Dec 8, 2025 •
edited
Loading

✅ Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit 4eb104c
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/69386712db49130008c0dfa8

@netlify
Copy link
Copy Markdown

netlify bot commented Dec 8, 2025 •
edited
Loading

✅ Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit 4eb104c
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/693867124d48c600087ad9ea
😎 Deploy Preview https://deploy-preview-5044--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@timdeschryver timdeschryver force-pushed the main-ci-v2 branch 3 times, most recently from e0d3711 to d2e86b2 Compare December 9, 2025 10:17
@timdeschryver
Copy link
Copy Markdown
Member Author

timdeschryver commented Dec 9, 2025 •
edited
Loading

The last issue is the failing snapshot tests.
Funny enough, these are green when running all tests, but are red when running the affected test.

@timdeschryver timdeschryver mentioned this pull request Dec 14, 2025
Merged
3 tasks
@timdeschryver timdeschryver changed the title [DO NOT MERGE] ci: fix remaining errors in main build ci: fix remaining errors in main build Dec 15, 2025
@brandonroberts
Copy link
Copy Markdown
Member

brandonroberts commented Dec 15, 2025

We could just switch the CI job to run all the tests like before. We've have issues with affected tests over the years for some reason.

@brandonroberts brandonroberts merged commit 037a6c4 into main Dec 15, 2025
13 of 14 checks passed
@brandonroberts brandonroberts deleted the main-ci-v2 branch December 15, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

@markostanimirovic markostanimirovic markostanimirovic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timdeschryver @brandonroberts @markostanimirovic