fix(router-store): set undefined for unserializable route title#3593
Merged
timdeschryver merged 1 commit intongrx:masterfrom Sep 30, 2022
Merged
Conversation
✅ Deploy Preview for ngrx-io ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
brandonroberts
approved these changes
Sep 30, 2022
timdeschryver
approved these changes
Sep 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3495
What is the new behavior?
MinimalRouterStateSerializersetsundefinedfor unserializable route title.Does this PR introduce a breaking change?
Other information
This is a temporary fix to avoid runtime errors when the
@ngrx/router-storepackage is used with a custom title resolver in Angular 14. I'll create another PR that completely resolves this issue when we move to Angular 15 (that includes this fix angular/angular#47459).