A few thoughts when updating my documentation for this:
- can ngrok-x64.exe be started hidden? There's already a start and stop button in the OverlayPlugin UI for this
- closing the ngrok-x64.exe command window doesn't update the UI to say it is stopped
- when restarting shared overlays (or switching tabs from shared to stream/local), the URL generator url doesn't update to reflect the new id
- the URL generator should ideally use
file:// urls for local files, as copying and pasting a local filename with a url query string escapes the question mark, e.g. C:\Users\tinipoutini\cactbot\ui\raidboss\raidboss.html?OVERLAY_WS=wss://75ee58f97e2e.ngrok.io/ws becomes file:///C:/Users/tinipoutini/cactbot/ui/raidboss/raidboss.html%3FOVERLAY_WS=wss://75ee58f97e2e.ngrok.io/ws in the url bar (this is clearly not something most people will do, but this is also true for stream/local overlays as well as shared, where it's more relevant)
- closing ACT should kill any open ngrok process so it doesn't have to be closed manually before starting it again
- "It works!" page should include ngrok query strings instead of local query strings if loaded over ngrok
- cactbot presets in the url generator all point to local files, but these need to be the gh-pages version to be loaded by others. Is there a way to add a presets for stream/local vs shared? Or is the future that everything is remote so I should just make all cactbot presets remote now?
- target bar urls in the url generator appear busted and look like
%/%/targetbars/etc. (Although, arguably these should not be included in the preset list for shared overlays, as we don't know the target for the remote user. Similarly, cactbot jobs.)
If you know what you're using an overlay that isn't listed, here are some query strings for you: should probably say If you know what you're doing and you're using an overlay that isn't listed...
- no feedback when the stream/local overlay can't open a port because ngrok is blocking it. You can repro this by: shared overlay -> start -> close ACT -> start ACT -> stream/local overlay -> start -> hang until ngrok exe is closed. It's worse that stream/local overlay says that it has started correctly so there is no indication something is wrong here.
- similarly, no feedback the other way around for ngrok not working because stream/local overlay is blocking it. You can repro this by: stream/local overlay -> start -> shared overlay -> start. ngrok says it starts correctly and stream/local overlay transitions to "failed", however stream/local overlay is the only one working and shared overlay does not work. I can't fix this state without restarting ACT and closing ngrok.
(Sorry for the giant list. I can open separate bugs if these are things you want to fix, but this just seemed cleaner to put all of the shared overlay/ngrok issues in one place.)
A few thoughts when updating my documentation for this:
file://urls for local files, as copying and pasting a local filename with a url query string escapes the question mark, e.g.C:\Users\tinipoutini\cactbot\ui\raidboss\raidboss.html?OVERLAY_WS=wss://75ee58f97e2e.ngrok.io/wsbecomesfile:///C:/Users/tinipoutini/cactbot/ui/raidboss/raidboss.html%3FOVERLAY_WS=wss://75ee58f97e2e.ngrok.io/wsin the url bar (this is clearly not something most people will do, but this is also true for stream/local overlays as well as shared, where it's more relevant)%/%/targetbars/etc. (Although, arguably these should not be included in the preset list for shared overlays, as we don't know the target for the remote user. Similarly, cactbot jobs.)If you know what you're using an overlay that isn't listed, here are some query strings for you:should probably sayIf you know what you're doing and you're using an overlay that isn't listed...(Sorry for the giant list. I can open separate bugs if these are things you want to fix, but this just seemed cleaner to put all of the shared overlay/ngrok issues in one place.)