Skip to content

Ensure watchers are enabled before handling NGINX config context update #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhurley merged 1 commit into from
Jan 6, 2026
Merged

Ensure watchers are enabled before handling NGINX config context update #1473

dhurley merged 1 commit into from
Jan 6, 2026

Conversation

@dhurley
Copy link
Collaborator

@dhurley dhurley commented Jan 6, 2026

Proposed changes

Ensure watchers are enabled before handling NGINX config context update.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley self-assigned this Jan 6, 2026
@dhurley dhurley requested a review from a team as a code owner January 6, 2026 13:51
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jan 6, 2026
@codecov
Copy link

codecov bot commented Jan 6, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.19%. Comparing base (f4a3c33) to head (bb6bee4).
⚠️ Report is 2 commits behind head on release-3.6.2.

Additional details and impacted files 
@@                Coverage Diff                @@
##           release-3.6.2    #1473      +/-   ##
=================================================
- Coverage          85.33%   85.19%   -0.14%     
=================================================
  Files                102      102              
  Lines              12993    12972      -21     
=================================================
- Hits               11088    11052      -36     
- Misses              1418     1435      +17     
+ Partials             487      485       -2
Files with missing lines Coverage Δ
internal/watcher/watcher_plugin.go 71.87% <100.00%> (-1.05%) ⬇️

... and 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a3c33...bb6bee4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dhurley dhurley mentioned this pull request Jan 6, 2026
Closed
6 tasks
@dhurley dhurley merged commit ef838cb into release-3.6.2 Jan 6, 2026
79 of 93 checks passed
@dhurley dhurley deleted the ensure-file-overview-update-is-sent branch January 6, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Akshay2191 Akshay2191 Akshay2191 approved these changes

@craigell craigell craigell approved these changes

@aphralG aphralG aphralG approved these changes

Assignees

@dhurley dhurley

Labels

chore Pull requests for routine tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhurley @Akshay2191 @craigell @aphralG