Fix compiling static lib on Windows with MSVC#1198
Open
sesmith177 wants to merge 2 commits intonghttp2:masterfrom
greenhouse-org:fix-static-lib-windows-vs
Open
Fix compiling static lib on Windows with MSVC#1198sesmith177 wants to merge 2 commits intonghttp2:masterfrom greenhouse-org:fix-static-lib-windows-vs
sesmith177 wants to merge 2 commits intonghttp2:masterfrom
greenhouse-org:fix-static-lib-windows-vs
Conversation
On Windows, the DLL will create nghttp2.lib AND nghttp2.dll. Then the static lib also tries to build nghttp2.lib, but that fails because it already exists. The nghttp2.lib created for the DLL cannot be used without the DLL. This compiles the static nghttp2.lib into a separate directory, which works around the above issue. Signed-off-by: Matthew Horan <mhoran@pivotal.io>
|
Friendly ping, we'd like to unblock Envoy Windows build support with this. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, the DLL will create nghttp2.lib AND nghttp2.dll. Then the
static lib also tries to build nghttp2.lib, but that fails because it
already exists.
The nghttp2.lib created for the DLL cannot be used without the DLL. This
compiles the static nghttp2.lib into a separate directory, which works
around the above issue.
Signed-off-by: Matthew Horan mhoran@pivotal.io