Fixed slantToImagePartials not operating in slant plane#613
Merged
JDanielSmith merged 1 commit intongageoint:masterfrom Dec 14, 2022
Merged
Fixed slantToImagePartials not operating in slant plane#613JDanielSmith merged 1 commit intongageoint:masterfrom
JDanielSmith merged 1 commit intongageoint:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The imageGridToECEF function is not always returning a point in the slant correctly so instead we use the SCP and imageToScene but pass the slant plane instead of the ground plane. Also changed the direction of the finite differences so that the slantRange and slantAzimuth vectors point in the + range/azimuth direction and the slant normal calculations aligns with figure 3.1 in the SICD IPDD.
Fixes #610
I did not find unit tests for the ProjectionModel class, but I ran the test script from 610 on all of the cropped NITFs and got the following results which align with what we would expect:
If there are automated tests for this class somewhere, I'm happy to add a new test to cover this.