remove errors/warnings from coda-oss

Dan Smith · Dan Smith · commit 5d8907616e5b · 2022-01-06T15:19:57.000-05:00
diff --git a/externals/coda-oss/modules/c++/except/include/except/Throwable.h b/externals/coda-oss/modules/c++/except/include/except/Throwable.h
@@ -320,7 +320,7 @@ class Throwable11 : public std::exception
         return toString() + backtrace;
     }
 
-    const char* what() const noexcept override final  // derived classes override toString()
+    const char* what() const noexcept final  // derived classes override toString()
     {
         // adding this to toString() output could (significantly) alter existing display
         mWhat = toString(true /*includeBacktrace*/);  // call any derived toString()
diff --git a/externals/coda-oss/modules/c++/logging/include/logging/Handler.h b/externals/coda-oss/modules/c++/logging/include/logging/Handler.h
@@ -88,10 +88,6 @@ struct Handler : public Filterer
     // for writing directly to stream, 
     // used for the bulk of the logging for speed
     virtual void emitRecord(const LogRecord* record) = 0;
-    virtual void emitRecord(const LogRecord& record)
-    {
-        return emitRecord(&record);
-    }
 
     LogLevel mLevel = LogLevel::LOG_NOTSET;
     sys::Mutex mHandlerLock;
diff --git a/externals/coda-oss/modules/c++/logging/include/logging/MemoryHandler.h b/externals/coda-oss/modules/c++/logging/include/logging/MemoryHandler.h
@@ -51,7 +51,7 @@ struct MemoryHandler : public Handler
 protected:
     virtual void write(const std::string& str);
 
-    virtual void emitRecord(const LogRecord* record);
+    void emitRecord(const LogRecord* record) override;
 
 private:
     typedef std::map<LogLevel, std::vector<std::string> > LogMap;
diff --git a/externals/coda-oss/modules/c++/logging/include/logging/StreamHandler.h b/externals/coda-oss/modules/c++/logging/include/logging/StreamHandler.h
@@ -71,7 +71,7 @@ struct StreamHandler : public Handler
 
     //! for writing directly to stream,
     // used for the bulk of the logging for speed
-    virtual void emitRecord(const LogRecord* record);
+    void emitRecord(const LogRecord* record) override;
 
     mem::auto_ptr<io::OutputStream> mStream;
 

Original file line number	Diff line number	Diff line change
`@@ -320,7 +320,7 @@ class Throwable11 : public std::exception`
`320`	`320`	`return toString() + backtrace;`
`321`	`321`	`}`
`322`	`322`
`323`		`- const char* what() const noexcept override final // derived classes override toString()`
	`323`	`+ const char* what() const noexcept final // derived classes override toString()`
`324`	`324`	`{`
`325`	`325`	`// adding this to toString() output could (significantly) alter existing display`
`326`	`326`	`mWhat = toString(true /includeBacktrace/); // call any derived toString()`