Skip to content

Support [FormControl] directive#99

Merged
allenhwkim merged 2 commits intong2-ui:masterfrom
ndcunningham:support-native-form-control
Jan 15, 2017
Merged

Support [FormControl] directive#99
allenhwkim merged 2 commits intong2-ui:masterfrom
ndcunningham:support-native-form-control

Conversation

@ndcunningham
Copy link
Copy Markdown
Member

@ndcunningham ndcunningham commented Jan 14, 2017

(feat) - If a [formControl] directive is used the auto-complete control should still update it's value, and not be forced to use formControlName or the form tag.

fixes: #100

@allenhwkim
Copy link
Copy Markdown
Contributor

@ndcunningham Do you need to update plunker example?

@ndcunningham
Copy link
Copy Markdown
Member Author

You want a plnkr for it?

@allenhwkim
Copy link
Copy Markdown
Contributor

We have an plunker example already as you seen in README.md
image

Do you need to update this to apply all your changes to users?

@ndcunningham
Copy link
Copy Markdown
Member Author

I'll build one separately and update

@allenhwkim
Copy link
Copy Markdown
Contributor

Thank you

@ndcunningham
Copy link
Copy Markdown
Member Author

ndcunningham commented Jan 15, 2017

@allenhwkim when you merge i will update the README.md linked it to #100

@allenhwkim allenhwkim merged commit 6bb1389 into ng2-ui:master Jan 15, 2017
@allenhwkim
Copy link
Copy Markdown
Contributor

merged and released 0.8.9

@ndcunningham ndcunningham deleted the support-native-form-control branch January 15, 2017 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - FormControl value does not update when item is selected or when values are entered

2 participants