add module for midas/run#2696
Merged
Merged
Conversation
Contributor
Author
|
Doing testing locally. Have a PR in at Bioconda to fix the container: bioconda/bioconda-recipes#38566 |
nvnieuwk
approved these changes
Jan 2, 2023
nvnieuwk
left a comment
Contributor
There was a problem hiding this comment.
A small comment otherwise LGTM
| @@ -0,0 +1,71 @@ | |||
| VERSION = '1.3.2' // WARN: Version information not provided by tool on CLI. Please update this string when bumping container versions. | |||
Contributor
There was a problem hiding this comment.
The VERSION variable should be inside the script part of the module, see: https://nf-co.re/docs/contributing/modules#general paragraph 4 :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #2695
versions.ymlfile.labelPROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-awarePROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-awarePROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-awareMIDAS requires a >30GB database, so had to go with a stub-run. Will have a rull test on the Bactopia side