Skip to content

add module for shigeifinder#2523

Merged
rpetit3 merged 4 commits into
nf-core:masterfrom
rpetit3:rp3-add-shigeifinder
Nov 19, 2022
Merged

add module for shigeifinder#2523
rpetit3 merged 4 commits into
nf-core:masterfrom
rpetit3:rp3-add-shigeifinder

Conversation

@rpetit3

@rpetit3 rpetit3 commented Nov 18, 2022

Copy link
Copy Markdown
Contributor

PR checklist

Closes #2522

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@rpetit3 rpetit3 added the new module Adding a new module label Nov 18, 2022
Comment thread modules/nf-core/shigeifinder/meta.yml Outdated

@SPPearce SPPearce left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go then.

@rpetit3

rpetit3 commented Nov 19, 2022

Copy link
Copy Markdown
Contributor Author

Thank you!

@rpetit3 rpetit3 merged commit daced79 into nf-core:master Nov 19, 2022
@rpetit3 rpetit3 deleted the rp3-add-shigeifinder branch November 19, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new module Adding a new module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new module: shigeifinder

2 participants