fix(web): render balance popup via portal to fix sidebar clipping#990
Merged
fix(web): render balance popup via portal to fix sidebar clipping#990
Conversation
…clipping The credit balance popup was being clipped by two overflow-hidden ancestors (sidebar shell and root layout). Render via createPortal to document.body with fixed positioning computed from the trigger button's bounding rect. Tooltip z-index also raised to ensure visibility. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The balance popup is rendered via portal to document.body, so clicks inside the portal are outside balanceRef. The mousedown click-outside handler was closing the popup before button onClick could fire. - Exclude the portal element from click-outside detection - Move setShowBalancePopup(false) after openExternalUrl call Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 409c14234f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Siri-Ray
approved these changes
Apr 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
overflow-hiddenon the sidebar shell and root layout containerscreatePortaltodocument.bodywithposition: fixed+getBoundingClientRect()positioningsetShowBalancePopup(false)afteropenExternalUrlto ensure the link opens before the popup unmountsCloses #964
Test plan
🤖 Generated with Claude Code