fix: show gifted credits in sidebar balance popup#985
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db51360030
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
added 2 commits
April 9, 2026 16:50
Deploying nexu-docs with
|
| Latest commit: |
2c90343
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://09ff0423.nexu-docs.pages.dev |
| Branch Preview URL: | https://fix-issue-910-gifted-credit.nexu-docs.pages.dev |
lefarcen
approved these changes
Apr 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the desktop sidebar balance popup so it shows current gifted and plan credit balances instead of reusing cumulative reward progress.
Why
Closes #910.
The popup was showing
progress.earnedCredits, which is a cumulative rewards metric, not the current gifted balance bucket. That made signup and reward credits appear in the total balance without appearing underGifted credits.How
giftedBalanceandplanBalancecloudBalance.giftedBalanceandcloudBalance.planBalanceinstead ofearnedCreditsAffected areas
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpassespnpm generate-typesrun (if API routes/schemas changed)anytypes introduced (useunknownwith narrowing)Screenshots / recordings
Manual verification in the sidebar popup showed:
Total credits = 400Gifted credits = 400Plan credits = 0Notes for reviewers
progress.earnedCredits; that field remains cumulative rewards progress for the rewards page.giftedBalance + planBalancenow tracks the current balance breakdown shown in the sidebar popup.