feat: align desktop settings with workspace design#984
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 525c4d8b67
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
lefarcen
approved these changes
Apr 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Align the desktop settings experience with the workspace design prototype, including the new in-workspace settings layout, desktop behavior controls, and resident-entry support.
Why
The existing settings page and sidebar behavior diverged from the latest workspace prototype and left several desktop-specific settings either missing or hard to discover. This change brings the desktop settings UX in line with the prototype and wires the key desktop shell controls into the real Electron runtime.
How
PageHeaderUI primitive and updated sidebar/footer navigation placement to match the prototype.Launch at startupandShow in Dock / taskbar, plus tray/menu-bar resident entry behavior when Dock/taskbar visibility is disabled.origin/maininto this branch and re-ran all local checks.Affected areas
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpassespnpm generate-typesrun (if API routes/schemas changed)anytypes introduced (useunknownwith narrowing)Notes for reviewers
Launch at startupandShow in Dock / taskbarnow persist in the desktop shell and apply at runtime.Data & Privacytoggles are intentionally frontend-only placeholders for now; they do not persist or invoke desktop-side behavior yet.Show in Dockon macOS andShow in taskbaron Windows now fall back to a resident menu bar / tray entry so the app remains recoverable when the main shell icon is hidden.