fix(dev): inject PLATFORM_TEMPLATES_DIR and harden controller startup wait#971
Merged
fix(dev): inject PLATFORM_TEMPLATES_DIR and harden controller startup wait#971
Conversation
Bots created via `pnpm dev start` were missing platform docs (AGENTS.md,
BOOTSTRAP.md, IDENTITY.md, ...) because the dev controller env never
received PLATFORM_TEMPLATES_DIR, so WorkspaceTemplateWriter silently
skipped the copy. The packaged desktop path (manifests.ts) sets it, but
dev mode runs the controller as a standalone supervisor and bypasses
that path entirely.
Three changes:
1. scripts/dev/src/shared/dev-runtime-config.ts:
inject PLATFORM_TEMPLATES_DIR pointing at apps/controller/static/platform-templates.
2. apps/controller/src/runtime/workspace-template-writer.ts:
promote the missing-platformTemplatesDir branch from debug to warn
so this regression is loud next time.
3. scripts/dev/src/{services,supervisors}/controller.ts:
bump the controller dev startup wait from 30 attempts (15s) to 120
(60s). Windows cold-start (tsx loader + bootstrap Promise.all) takes
~15s and was timing out on the listener-bind boundary, blocking
`pnpm dev restart controller`.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02fc757acf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
PerishCode
approved these changes
Apr 9, 2026
When the controller supervisor crashes on start, the port wait now exits immediately instead of polling for the full 60s timeout. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PLATFORM_TEMPLATES_DIRinto dev controller env so bots created viapnpm dev startreceive platform docs (AGENTS.md, BOOTSTRAP.md, IDENTITY.md, etc.). The packaged desktop path sets it viamanifests.ts, but dev mode bypasses that entirely.platformTemplatesDirlog fromdebugtowarnso this regression is loud next time.Promise.all) was timing out on the listener-bind boundary.Test plan
pnpm dev start→ create a new bot → verify AGENTS.md / BOOTSTRAP.md appear in workspace🤖 Generated with Claude Code