fix(rewards): simplify GitHub star reward verification#942
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6de8e6a99b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
mrcfps
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Simplify the GitHub Star reward flow so the desktop app opens GitHub, shows a short verification toast, and claims the reward without depending on a live GitHub star-count check.
Why
The public GitHub stars endpoint is rate-limited and not realtime, so users can successfully star the repo and still fail verification immediately afterward.
How
prepareSession()best-effort so GitHub API hiccups do not block the flowverifySession()trust the short desktop verification window instead of refetching the GitHub star countAffected areas
Checklist
pnpm typecheckpasses (blocked in this worktree: dependencies / local tools missing,tscnot found)pnpm lintpasses (blocked in this worktree:biomenot found)pnpm testpasses (blocked in this worktree:vitestnot found)pnpm generate-typesrun (if API routes/schemas changed)anytypes introduced (useunknownwith narrowing)Notes for reviewers
The cloud rewards claim endpoint already enforces per-account de-dup via
alreadyClaimed, so this flow remains single-claim even though the desktop verification path no longer depends on the GitHub API response.